Re: [PATCH] hfs+ uuid

[Vladimir 'phcoder' Serbinenko]

On Tue, Jun 9, 2009 at 12:01 AM, Pavel Roskin<address@hidden> wrote:
> On Mon, 2009-06-08 at 22:50 +0200, Vladimir 'phcoder' Serbinenko wrote:
>
>> Here is the improved patch. I deliberately ignored md5 comments
>> because this part will be gone anyway whel Michael Gorven signs his
>> copyright assignment and we incorporate luks patches
>
> Please consider if it would be better to supply the filesystem UUID on
> the command line rather than the device name.  That would make xnu_uuid
> leaner and more flexible.  I think we need the "uuid" command that would
> get the uuid and the "xnu_uuid" command that would convert it.
>
> It would be great if you run xnu_uuid.c through indent.  The coding
> style is quite different from that used elsewhere in GRUB.  Or at least
> please strip trailing spaces.
>
> "file name required" is a wrong error message.  It should be "device
> file required".  I think it would be better to expand "fs" and "FS" in
> error messages as "filesystem".
>
> If the variable name is not specified, I think xnu_uuid should just
> output the UUID without any explanations.  Explanations belong to the
> help, not to the normal output.
GRUB2 becomes increasingly more complex. We try to document it on
grub.enbug.org but when user needs the info the most his only system
is unbootable. Perhaps we should incorporate a more extensive help
into grub2 itself. man format looks rather easy to parse
>
> "(void)mod;" is not needed.  The "buf" variable in grub_cmd_xnu_uuid()
> is unused.
>
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

hfspuuid.diff
Description: Text Data