Re: [PATCH] savedefault

[Robert Millan]

Hi!

On Mon, Jun 01, 2009 at 12:48:38PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>  cat << EOF
> +load_env
>  set default=${GRUB_DEFAULT}

Does the "set" line override the settings in load_env?  It looks like it
would.

> --- a/util/grub.d/10_freebsd.in
> +++ b/util/grub.d/10_freebsd.in
> @@ -57,6 +57,8 @@ if [ "x$kfreebsd" != "x" ] ; then
>  
>    cat << EOF
>  menuentry "${OS}" {
> +  saved_entry=\${chosen_entry}
> +  save_env saved_entry
>  EOF
>    prepare_grub_to_access_device ${GRUB_DEVICE_BOOT} | sed -e "s/^/\t/"
>    cat << EOF
> diff --git a/util/grub.d/10_hurd.in b/util/grub.d/10_hurd.in
> index 12d61b0..114017b 100644
> --- a/util/grub.d/10_hurd.in
> +++ b/util/grub.d/10_hurd.in
> @@ -70,6 +70,8 @@ fi
>  
>  cat << EOF
>  menuentry "${OS}" {
> +  saved_entry=\${chosen_entry}
> +  save_env saved_entry
>  EOF
>  prepare_grub_to_access_device ${GRUB_DEVICE} | sed -e "s/^/\t/"
>  cat << EOF
> diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in
> index c2da413..93d141b 100644
> --- a/util/grub.d/10_linux.in
> +++ b/util/grub.d/10_linux.in
> @@ -97,6 +97,8 @@ linux_entry ()
>  {
>    cat << EOF
>  menuentry "$1" {
> +  saved_entry=\${chosen_entry}
> +  save_env saved_entry
>  EOF
>    prepare_grub_to_access_device ${GRUB_DEVICE_BOOT} | sed -e "s/^/\t/"
>    cat << EOF

I think it'd really be a good idea to either factorize this into a function
(ala prepare_grub_to_access_device), or make it part of the scripting engine.
I'm afraid of the possibility that later we want to change something and can't
because 3rd party scripts depend on it (this happened with disk selection
before we had prepare_grub_to_access_device).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."