Re: [PATCH 6/18] define asm constant for absolute memory access

[Pavel Roskin]

On Sat, 2009-05-30 at 16:46 +0200, Vladimir 'phcoder' Serbinenko wrote:
> +#ifdef APPLE_CC
> +#define MSG(x) x ## _abs = ABS(x); movw $x ## _abs, %si; call message
> +#else
>  #define MSG(x) movw $ABS(x), %si; call message
> +#endif

I have verified that defining APPLE_CC on Fedora would produce exactly
the same bytecode.  I don't see any reason to have preprocessor
conditionals all over the place.  Are you trying to support as without
variables?

> +#ifdef APPLE_CC
> +       movl $(mmaphook_mmap_rel), %esi
> +#else
>         movw $(DS(mmaphook_mmap)), %si
> +#endif

That's not an equivalent replacement.  The argument width is different.

-- 
Regards,
Pavel Roskin