grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix for loading modules from read-only memory area (Re: clea


From: Robert Millan
Subject: Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port))
Date: Fri, 26 Jun 2009 19:43:33 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Fri, Jun 26, 2009 at 01:16:57PM -0400, Pavel Roskin wrote:
> > But as for 02-elf-renames.patch we could try to make this more consistent.  
> > In
> > efiemu I used 'W' (inspired by ElfW() macro in glibc), then in some places 
> > you
> > use 'K' and in other places 'T'.  Can we use the same everywhere?  I don't
> > care which letter, I'm not THAT much into bikeshed :-)
> 
> "T" stands for "target" and "K" stands for "kernel".  Yes, we can use
> ElfW everywhere.  But I would try to avoid any mass renames.  It's very
> easy to write Elf instead of ElfW somewhere in the code, and it would
> compile, but it won't work.

Ok, I don't mind.  Unless you have any objections, I'll merge your two
patches with mine and commit that.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]