[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] Improve genmoddep.awk
From: |
Robert Millan |
Subject: |
Re: [PATCH 1/3] Improve genmoddep.awk |
Date: |
Wed, 1 Jul 2009 15:13:11 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Jul 01, 2009 at 01:22:29PM +0800, Bean wrote:
> On Wed, Jul 1, 2009 at 12:51 PM, Pavel Roskin<address@hidden> wrote:
> > Quoting Bean <address@hidden>:
> >
> >> Perhaps you could also take a look at my previous patch
> >>
> >> [PATCH] Use symbol database to maintain module dependence
> >>
> >> It add a program grub-symdb to maintain symbol database and therefore
> >> eliminate def- and unf- files, it also allows incremental build.
> >
> > grub-symdb would need to be compiled by a native C compiler. Otherwise, it
> > won't work when cross-compiling the utilities.
> >
> > It's not that it's a big deal per se, but it is will add complexity if we
> > try to use autoconf to look for it.
> >
> > Adding grub-symdb to bin_UTILITIES would result in it being installed along
> > with the utilities that are actually used after the build. I think it's
> > wrong. Temporary build tools don't belong there.
>
> Hi,
>
> Actually, that's the intention. grub-symdb and the symbol database is
> supposed to be installed in the target system. They can be used to
> support external grub modules. To install new package, we can just
> copy the modules files and use rerun grub-symdb to update the
> database.
I tend to agree with Pavel. We should be careful about adding complexity,
and only do it when we're sure it's going to pay off.
(I'm not saying it doesn't pay off here, but this factor should always be
taken into account IMO)
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."