Re: [PATCH] File access library for lua

[Duboucher Thomas]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

        I was reading the code and now I have a question. You are creating a
grub librairy writen in C including useful functions such as
'grub.file_open'. But in your implementation, you removed base libraries
such as 'os' and 'io'. So why don't you just rewrite 'io.open' instead
of creating 'grub.file_open'?

        Thomas.

Bean a écrit :
> Committed.
> 
> On Sat, Jun 27, 2009 at 12:14 PM, Bean<address@hidden> wrote:
>> On Sat, Jun 27, 2009 at 12:04 PM, Pavel Roskin<address@hidden> wrote:
>>> On Sat, 2009-06-27 at 11:53 +0800, Bean wrote:
>>>
>>>> Yes, actually it's just a bunch of file_exist AND or OR together, but
>>>> I think if we use this kind of test often enough, implement it in c
>>>> would be more efficient.
>>> So far, we only have one file.
>>>
>>> I checked the Lua reference manual, and no file related functions take
>>> lists of filenames:
>>>
>>> http://www.lua.org/manual/5.1/
>>>
>>> If it was ineffective, I think Lua developers would have designed the
>>> file access differently.
>> All right then, I'd change it back to single parameter. Actually it's
>> not a big deal, but I just hate long lines, :)
>>
>> --
>> Bean
>>
> 
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpQpmcACgkQBV7eXqefhqjZkgCfdigjl2N7DFu3xxNCLDbyMerP
AyEAoKzDcOW6ebJtdEIUcNSB9q57q64G
=fJix
-----END PGP SIGNATURE-----