Re: OLPC regression, ofdisk stops working

[Bean]

On Sat, Jul 11, 2009 at 4:20 AM, Robert Millan<address@hidden> wrote:
> On Fri, Jul 10, 2009 at 11:18:28AM -0700, David Miller wrote:
>> From: Robert Millan <address@hidden>
>> Date: Fri, 10 Jul 2009 19:41:15 +0200
>>
>> > On Fri, Jul 10, 2009 at 10:28:03PM +0800, Bean wrote:
>> >> Hi,
>> >>
>> >> There is something wrong with r2132, now childtype is a pointer, so
>> >> sizeof childtype == 4, the name would be truncated to 4 characters.
>> >
>> > Bean, you never cease to amaze me.  I admit the "interesting, exactly
>> > the word size" idea crossed my head, but I didn't reach any conclussion
>> > out of it :-)
>> >
>> > Nice catch.  Will you commit this, or want me to?
>>
>> Good catch, I thought I had gotten all of those size
>> conversions correct, guess not :-/
>
> Don't worry about it, shit happens.
>
> Btw, I just committed it.  I found another instance of the same problem in
> that file, which I fixed as well.

Hi,

Oh nice. BTW, I just notice a small error in my previous patch, the
size of childname is IEEE1275_MAX_PROP_LEN instead of
IEEE1275_MAX_PATH_LEN, I've committed the fix now.

-- 
Bean