Re: [PATCH 2/3] Eliminate grub_dl_call_init()

[Vladimir 'phcoder' Serbinenko]

On Wed, Jul 22, 2009 at 2:47 AM, Pavel Roskin<address@hidden> wrote:
> It's just two lines long and there is only one caller.  Besides, there
> is no equivalent for mod->fini.
This patch is fine for me
>
> ChangeLog:
>
>        * kern/dl.c (grub_dl_call_init): Remove.
>        (grub_dl_load_core): Call mod->init directly.
> ---
>  kern/dl.c |   10 ++--------
>  1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/kern/dl.c b/kern/dl.c
> index ebde547..e2382d6 100644
> --- a/kern/dl.c
> +++ b/kern/dl.c
> @@ -393,13 +393,6 @@ grub_dl_resolve_symbols (grub_dl_t mod, Elf_Ehdr *e)
>   return GRUB_ERR_NONE;
>  }
>
> -static void
> -grub_dl_call_init (grub_dl_t mod)
> -{
> -  if (mod->init)
> -    (mod->init) (mod);
> -}
> -
>  static grub_err_t
>  grub_dl_resolve_name (grub_dl_t mod, Elf_Ehdr *e)
>  {
> @@ -559,7 +552,8 @@ grub_dl_load_core (void *addr, grub_size_t size)
>
>   mod->ref_count = 1;
>
> -  grub_dl_call_init (mod);
> +  if (mod->init)
> +    (mod->init) (mod);
>
>   return mod;
>  }
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git