Re: [PATCH 2/2] SDL support

[Vladimir 'phcoder' Serbinenko]

On Thu, Jul 23, 2009 at 10:32 PM, Pavel Roskin<address@hidden> wrote:
> On Thu, 2009-07-23 at 11:49 +0200, Vladimir 'phcoder' Serbinenko wrote:
>> Hello. Here is already-discussed SDL support
>
> The patch refers to video/fb/video_fb.c, which is not included.
Well it's PATCH 2/2 and PATCH 1/2 is framebuffer split which is the
pre-requisite for this patch. I had some problems with sending but now
I checked the archives and see that the patch 1 successfully arrived
>
> Also, please check the changes I made to your changes to configure.ac.
> Please check the spelling of "explicitly".  There is no need for verbose
> excuses, it's enough to say "need SDL library" or "need SDL headers".
>
> "build and install the `grub-emu' debugging utility with SDL support" is
> also too long and not quite correct.  --enable-grub-emu-sdl decides
> whether SDL support will be in grub-emu.  Since it's the default, maybe
> it's better to describe --disable-grub-emu-sdl.  Obviously, it applies
> to grub-emu-usb as well, I just didn't have a chance to clean it up.
>
Agreed. Will fix at better time of the day
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git