Re: [Fwd: Bug#503344: Grub-pc fails on IBM x3250 configured with RAID-1]

[Felix Zielcke]

Am Samstag, den 25.07.2009, 10:37 +0200 schrieb Vladimir 'phcoder'
Serbinenko:
> On Sat, Jul 25, 2009 at 1:35 AM, Felix Zielcke<address@hidden> wrote:
> > Is this an acceptable fix?
> > Though I have the feeling this isn't a proper one.
> >
> >>
> >> The fix is to assign grub_errno before making the call to
> >> grub_file_get_device_name():
> Just check whether returned device_name is 0 or not

Ok, I should have checked the actual code. That was pretty clear.
Sorry for the noise.

> >>
> >> diff --git a/kern/file.c b/kern/file.c
> >> index adf55da..5e605f9 100644
> >> --- a/kern/file.c
> >> +++ b/kern/file.c
> >> @@ -59,6 +59,7 @@ grub_file_open (const char *name)
> >>     char *device_name;
> >>     char *file_name;
> >>
> >> +  grub_errno = GRUB_ERR_NONE;  /* Used as error flag */
> >>     device_name = grub_file_get_device_name (name);
> >>     if (grub_errno)
> >>       return 0;
> >
> >
> > --
> > Felix Zielcke
> > Proud Debian Maintainer
> >
> >
> >
> > _______________________________________________
> > Grub-devel mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/grub-devel
> >
> 
> 
> 


-- 
Felix Zielcke
Proud Debian Maintainer