[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch to compile boot.img properly on OSX
From: |
Vladimir 'phcoder' Serbinenko |
Subject: |
Re: Patch to compile boot.img properly on OSX |
Date: |
Thu, 30 Jul 2009 11:57:51 +0200 |
On Thu, Jul 30, 2009 at 7:37 AM, Pavel Roskin<address@hidden> wrote:
> On Wed, 2009-07-29 at 11:14 +0200, Yves Blusseau wrote:
>> Hi,
>>
>> Pavel, is it ok to commit the patch so we can generate boot.img from
>> OSX ? (using L_ label as far as i remember).
>
> In response to that patch, I was requested to create a private grub
> repository with separate branches for every patch.
>
> I'll need to do that or write an explanation why I won't do it. At the
> moment, I don't have time for either of that.
>
This wasn't specific for the patch. Neither was it a requirement, but
more an idea. It's your work and you can choose to do it the way you
like.
> I don't think it would be a good idea to commit a patch if there is a
> pending request for action and no approvals, especially since it was a
> request for testing.
>
> Besides, this patch only fixes one file. We have several images that
> need the same treatment.
Since Yves is interested perhaps he could do the "dirty job" of
applying repetitive fixes and testing different images? And submit a
patch then?
> Also, the problem with lnxboot.S spilled into
> the build system. This will need to be cleaned up as well.
>
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git