Re: 2273 lines in 170 files consists of only space and tabulators

[Felix Zielcke]

Am Freitag, den 31.07.2009, 17:39 +0200 schrieb Robert Millan:
> On Tue, Jul 28, 2009 at 11:09:11PM +0200, Felix Zielcke wrote:
> > Am Dienstag, den 28.07.2009, 20:19 +0200 schrieb Robert Millan:
> > > On Wed, Jun 10, 2009 at 11:04:56PM +0200, Felix Zielcke wrote:
> > > > Am Samstag, den 06.06.2009, 21:53 -0400 schrieb Pavel Roskin:
> > > > > On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote:
> > > > > > address@hidden:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|wc -l
> > > > > > 2273
> > > > > > address@hidden:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|sed -e 
> > > > > > 's/:.*//'|uniq|wc -l
> > > > > > 170
> > > > > > 
> > > > > > Anyone wants me to do 
> > > > > > find . -type f -print0 | xargs -0 sed -i -r -e 's/^[[:blank:]]+$//'
> > > > > > or does someone object?
> > > > > > [:blank:] doestn't contain these ^L chars.
> > > > > > 
> > > > > > By the way `git diff --color' shows if you introduce such a line 
> > > > > > with
> > > > > > red, but strangely not when you remove one.
> > > > > 
> > > > > Since we have linear development, it shouldn't be a problem for 
> > > > > merging
> > > > > patches.  Besides, "patch" can be told to ignore whitespace 
> > > > > differences.
> > > > > 
> > > > > However, I would prefer that we remove all trailing whitespace, not 
> > > > > just
> > > > > that on empty lines.  That is, remove "^" from the sed expression.
> > > > 
> > > > Ok I just commited this.
> > > 
> > > Do you mean removing all whitespace?  I think you forgot to commit it.
> > > 
> > > Though, I'd prefer if we don't do this in one megacommit.  If we do it
> > > gradually, we avoid breaking patches.  This makes work easier for branches
> > > and for distributors (which essentially operate as a branch).
> > 
> > I did this in r2293
> > So you even didn't notice this. Good :)
> 
> But there was no ChangeLog entry?
> 

Uhm I thought this wasn't needed because the actual code didn't change.
But okay GCS talks about all changes made to source files so you're
probable right.

-- 
Felix Zielcke
Proud Debian Maintainer