Re: [PATCH] Some documentation updates

[Vladimir 'phcoder' Serbinenko]

On Wed, Sep 2, 2009 at 11:06 AM, Colin Watson<address@hidden> wrote:
> I'm afraid I temporarily ran out of steam at this point, so there are
> still lots of commands to go, but here's a start. Does this look OK?
>
> 2009-09-02  Colin Watson  <address@hidden>
>
>        * docs/grub.texi: Describe one-based partition numbering.
>        Document acpi, blocklist, crc, export, insmod, keystatus, ls,
>        set, and unset commands.
>
Could you perhaps explicitly mention sections updated?
> -example is @samp{(hd0,0)/boot/grub/menu.lst}. This means the file
> +example is @samp{(hd0,1)/boot/grub/menu.lst}. This means the file
> address@hidden/boot/grub/menu.lst} in the first partition of the first hard
Please remove references to menu.lst. It's not wrong in this context
but still confusing

Other than this patch is good. I don't think it needs more review. You
can commit it.
-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git