Re: [PATCH] 64-bit file sizes in NTFS

[Robert Millan]

On Thu, Sep 10, 2009 at 08:24:44PM +0100, Colin Watson wrote:
> On Thu, Sep 10, 2009 at 09:17:54PM +0200, Robert Millan wrote:
> > On Thu, Sep 10, 2009 at 05:39:14PM +0100, Colin Watson wrote:
> > > Index: include/grub/ntfs.h
> > > ===================================================================
> > > --- include/grub/ntfs.h   (revision 2584)
> > > +++ include/grub/ntfs.h   (working copy)
> > > @@ -133,7 +133,7 @@ struct grub_fshelp_node
> > >  {
> > >    struct grub_ntfs_data *data;
> > >    char *buf;
> > > -  grub_uint32_t size;
> > > +  grub_uint64_t size;
> > >    grub_uint32_t ino;
> > >    int inode_read;
> > >    struct grub_ntfs_attr attr;
> > 
> > Would this change offsets in subsequent struct fields?  (I notice it's not
> > packed, but I always forget the alignment rules...)
> 
> It probably would, but I don't think anything cares, does it? This data
> structure is purely internal - it isn't read from disk in a way that
> expects structures to line up.

Oh, right.  I thought it was some NTFS structure.

You can commit this.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."