Re: [PATCH] Create environment block safely

[address@hidden]

On Wed, Sep 30, 2009 at 5:54 PM, Colin Watson <address@hidden> wrote:
> If grub-editenv create is interrupted, it's theoretically possible for
> it to create an incomplete block that future grub-editenv calls won't
> recognise. It would be better for it to atomically create either a
> complete block or nothing. Any objections?

Be aware that this may lose security settings.  Write-in-place is also
different wrt hard links, but it would be pretty odd for that file to
have additional hard links.

You might also need to check for the alternate name, in case the
operation failed after writing the new content and unlinking the old
file, but before renaming the new file.