Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU

[Vladimir 'phcoder' Serbinenko]

Robert Millan wrote:
> Hi,
>
> I didn't notice this mail untill a few minutes ago (was still in fetch
> queue), so my first patch was already checked in.
>
> On Fri, Oct 09, 2009 at 01:10:12AM +0200, Vladimir 'phcoder' Serbinenko wrote:
>   
>>> Index: include/grub/i386/cpuid.h
>>> ===================================================================
>>> --- include/grub/i386/cpuid.h       (revision 0)
>>> +++ include/grub/i386/cpuid.h       (revision 0)
>>>       
>> This file doesn't follow convention of having an ifdef around the file
>>     
>
> Thanks, I've added it now.
>
>   
>>> +extern unsigned char grub_cpuid_has_longmode;
>>>       
>> I don't like it being declared as a variable: user may inadvertently assign 
>> a value to it. I would be more confortable with a function
>>     
>
> I tend to prefer a (const) function too, but this required some restructuring
> in cpuid.c so for 1.97 I opted for keeping the changes minimal.
>
>   
Why would these changes be intrusive? It's just a function returning  a
static value or did I miss something?

-- 
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git