Re: [PATCH] Add support for (pxe[:server_ip[:gateway_ip]]) and export pxe parameteres into grub environment

[Seth Goldberg]

 +1 :).

 --S

Quoting Robert Millan, who wrote the following on Thu, 24 Dec 2009:

> Hi,
>
> On Sun, Dec 20, 2009 at 08:26:01PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko 
> wrote:
> > --- ChangeLog.pxeenv    1970-01-01 00:00:00 +0000
> > +++ ChangeLog.pxeenv    2009-12-20 19:23:11 +0000
> > @@ -0,0 +1,36 @@
> > +2009-12-19  Vladimir Serbinenko  <address@hidden>
> > +
> > +       Support for (pxe[:server[:gateway]]) syntax and
> > +       use environment variable for PXE.
> > +
> > +       * commands/i386/pc/pxecmd.c (options): Removed.
> > +       (print_ip): Removed.
> > +       (grub_cmd_pxe): Removed
> > +       (grub_cmd_pxe_unload): New function.
> > +       * fs/i386/pc/pxe.c (grub_pxe_disk_data): New structure.
> > +       (grub_pxe_your_ip): Made static.
> > +       (grub_pxe_default_server_ip): Likewise.
> > +       (grub_pxe_default_gateway_ip): Likewise.
> > +       (grub_pxe_blksize): Likewise.
> > +       (parse_ip): New function.
> > +       (grub_pxe_open): Support server and gateway specification.
> > +       (grub_pxe_close): Free disk->data.
> > +       (grub_pxefs_open): Use disk->data.
> > +       (grub_pxefs_read): Likewise.
> > +       (grub_env_write_readonly): New function.
> > +       (set_mac_env): Likewise.
> > +       (set_env_limn_ro): Likewise.
> > +       (parse_dhcp_vendor): Likewise.
> > +       (grub_pxe_detect): Set the environment variables.
> > +       (set_ip_env): New function.
> > +       (write_ip_env): Likewise.
> > +       (grub_env_write_pxe_default_server): Likewise.
> > +       (grub_env_write_pxe_default_gateway): Likewise.
> > +       (grub_env_write_pxe_blocksize): Likewise.
> > +       (GRUB_MOD_INIT(pxe)): Set environment variables.
> > +       * include/grub/i386/pc/pxe.h (grub_pxe_mac_addr): Rename to ...
> > +       (grub_pxe_mac_addr_t): ... this. All users updated.
> > +       (grub_pxe_your_ip): Removed.
> > +       (grub_pxe_server_ip): Likewise.
> > +       (grub_pxe_gateway_ip): Likewise.
> > +       (grub_pxe_blksize): Likewise.
>
> This can go directly to trunk, if you consider it suitable.
>
> --
> Robert Millan
>
>  "Be the change you want to see in the world" -- Gandhi
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel