[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix getline name clash
|
From: |
Grégoire Sutre |
|
Subject: |
Re: [PATCH] Fix getline name clash |
|
Date: |
Fri, 24 Sep 2010 12:37:07 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.9.1.11) Gecko/20100723 Lightning/1.0b2pre Shredder/3.0.6 |
On 09/24/2010 12:18, Colin Watson wrote:
This looks good to me as far as it goes, but doesn't it need a bit more?
I guess we should not rename the actual calls to the getline() library
function (otherwise gnulib's replacement won't help). And I personally
don't mind if function arguments and local variables are substituted.
But I agree that, in general, it would be safer to avoid names that
might be inadvertently replaced by gnulib's #defines.
Grégoire