Re: GRUB warning level increase

[Grégoire Sutre]

On 02/10/2012 05:00 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Hello, all. I have increased the warning level in GRUB. This is done for
> quicker discovery and correction of the bugs which would be otherwise
> hard to track. Mostly it enabled warnings regarding guidelines which are
> already followed by GRUB.

On Debian GNU/Linux amd64 with GCC 4.6.2, I get a number of warnings
triggered by -Wunsafe-loop-optimizations. The first one is:

commands/lsacpi.c: In function 'grub_cmd_lsacpi':
commands/lsacpi.c:135:3: error: cannot optimize loop, the loop counter 
may overflow [-Werror=unsafe-loop-optimizations]
commands/lsacpi.c:166:3: error: cannot optimize loop, the loop counter 
may overflow [-Werror=unsafe-loop-optimizations]
cc1: all warnings being treated as errors

The attached patch fixes it.  The remaining ones are, afaics, either
false positives or potential overflows in loops of the form:

        for (i = 1; i <= foo; i++) { ... }

where i and foo have the same type (e.g., int).  I'm not sure how to
properly fix those (declare i with a wider type? replace i by i+1 in
the whole loop to make the condition become i < foo?).

Grégoire

check-len.diff
Description: Text Data