Re: Lists and aliasing (Re: Freeze on 27 February)

[Lennart Sorensen]

On Wed, Feb 22, 2012 at 04:57:11PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko 
wrote:
> 
> >So with this patch, gcc 4.4 is down to 201 warnings, and gcc 4.6 has 175.
> 
> > 102 of those warnings are about missing prototypes for argp_usage
> > _option_is_short and _option_is_end in argp.h which leaves 99 warnings
> > for gcc 4.4 and 73 for gcc 4.6.
> 
> Hm we don't add -Wmissing-prototypes for utils

Well it is in WARN_FLAGS and TARGET_CFLAGS in configure.

And during build:
gcc-4.4 -DHAVE_CONFIG_H -I. -I../..  -Wall -W -I./include -DGRUB_UTIL=1 
-DGRUB_LIBDIR=\"/usr/lib/grub\" -DLOCALEDIR=\"/usr/share/locale\"  
-DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1 
-DGRUB_FILE=\"util/grub-mkimage.c\" -I. -I../.. -I. -I../.. -I../../include 
-I./include -I./grub-core/gnulib -I../../grub-core/gnulib 
-DGRUB_PKGLIBROOTDIR=\"/usr/lib/grub\"   -g -Wall -O2 -Wall -W -Wshadow 
-Wold-style-declaration -Wold-style-definition -Wpointer-arith -Wundef -Wextra 
-Waddress -Warray-bounds -Wattributes -Wbuiltin-macro-redefined -Wcast-align 
-Wchar-subscripts -Wclobbered -Wcomment -Wcoverage-mismatch -Wdeprecated 
-Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wempty-body 
-Wendif-labels -Wfloat-equal -Wformat-contains-nul -Wformat-extra-args 
-Wformat-security -Wformat-y2k -Wignored-qualifiers -Wimplicit 
-Wimplicit-function-declaration -Wimplicit-int -Winit-self 
-Wint-to-pointer-cast -Winvalid-pch -Wunsafe-loop-optimizations -Wlogical-op 
-Wmain -Wmissing-braces -Wmissing-field-initializers -Wmissing-format-attribute 
-Wmissing-noreturn -Wmudflap -Wmultichar -Wnonnull -Woverflow 
-Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-to-int-cast 
-Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-aliasing 
-Wswitch -Wsync-nand -Wtrigraphs  -Wtype-limits -Wundef -Wuninitialized 
-Wunknown-pragmas -Wunused -Wunused-function -Wunused-label -Wunused-parameter 
-Wunused-result -Wunused-value  -Wunused-variable -Wvariadic-macros 
-Wvolatile-register-var -Wwrite-strings -Wmissing-declarations 
-Wmissing-parameter-type  -Wmissing-prototypes -Wnested-externs 
-Wstrict-prototypes -Wpointer-sign -Wno-undef -Wno-sign-compare -Wno-unused 
-Wno-unused-parameter -Wno-redundant-decls -Wno-unreachable-code 
-Wno-conversion -Wno-old-style-definition   -c -o 
util/grub_mkimage-grub-mkimage.o `test -f 'util/grub-mkimage.c' || echo 
'../../'`util/grub-mkimage.c
In file included from ../../util/grub-mkimage.c:45:
../../grub-core/gnulib/argp.h:610: warning: no previous prototype for 
'argp_usage'
../../grub-core/gnulib/argp.h:616: warning: no previous prototype for 
'_option_is_short'
../../grub-core/gnulib/argp.h:628: warning: no previous prototype for 
'_option_is_end'

So something sure adds it.

-- 
Len Sorensen