Re: [PATCH] Making exported variables really global

[Andreas Vogel]

Am 04.03.2012 14:18, schrieb Vladimir 'φ-coder/phcoder' Serbinenko:
> On 04.03.2012 14:08, Andreas Vogel wrote:
>> Hi all,
>>
>> This tiny patch makes exported variables really global. Right now
>> exported variables are set in the context of a submenu when running it.
>> But any changes to those vars are lost when leaving the submenu. This
>> patch sets and exports all vars in the calling context for the submenu
>> which are exported in the context of the submenu.
> We follow the bash behaviour. And the bash behaviour is exactly what
> GRUB does:
> address@hidden:14:15:11:~/grub2/bzr/mainline$ bash
> address@hidden:14:15:15:~/grub2/bzr/mainline$ export XYZ=x
> address@hidden:14:15:19:~/grub2/bzr/mainline$ exit
> address@hidden:14:15:20:~/grub2/bzr/mainline$ echo $XYZ
>
> address@hidden:14:15:24:~/grub2/bzr/mainline$
>
I understand your point, but IMHO we do need to be able to set global
vars in submenus, that's my patch about.

Otherwise how can you use a "Settings..." submenu to configure
environment variables which are used by other menu entries for booting?
The analogy with bash is not useful here.