Re: pxe failing on grub 2.00 for files larger than 50KiB

[Daniel Kahn Gillmor]

On 09/25/2012 03:09 PM, Seth Goldberg wrote:
>  Is it possible that debian mismerged some changes from 2.00?  

no, i don't think so.  the tarball that debian's 2.00-5 package i used
has this sha1 sum:

274d91e96b56a5b9dd0a07accff69dbb6dfb596b  ../grub2_2.00.orig.tar.xz

which is the same as the upstream tarball i find at

 ftp://ftp.gnu.org/gnu/grub/grub-2.00.tar.xz

and that has a date of June 28, while r4505 has a date of June 22nd.

> There is
> code in tftp.c that stalls TFTP responses if >= 50 packets are queued by
> the network driver.  That packet count is increased by one each time
> grub_net_put_packet is called and decreased by one each time
> grub_net_receive_packet is called.  Those packet count changes went into
> revision 4505 (Implement flow control for tftp).

hmm, r4505 introduces a hard limit of 200 in grub-core/net/tftp.c, but
the grub tarball seems to have a hard limit of 50, apparently introduced
in r4508.

come to think of it, i see grub_net_put_packet() (which increments
packs.count) in grub-core/net/tftp.c, but i see no evidence that
grub_net_remove_packet() ever gets called there.

is there something else i should look into?

        --dkg

signature.asc
Description: OpenPGP digital signature