grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patch for better size handling of GRUB edit or shell


From: Dr. Tilmann Bubeck
Subject: Patch for better size handling of GRUB edit or shell
Date: Sun, 07 Oct 2012 14:14:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1

Hi

especially on low resolution systems (e.g. VirtualBox with 800x600) the GRUB edit window (gfxmenu/view.c) and GRUB shell are hard to use, because they only use 70% of the available width, which is 800px * 70% = 560px. Using the borders around the view makes the window even smaller. Please find attached a screenshot ("grub-unchanged-640x480-editor.png") showing the unmodified GRUB running in gfxmode=auto which is 800x600. You can see, that the edit window is ridiculus small.

Please find attached a patch, which changes the way, the view size is constructed. Before the patch it always used 70% of the available width. The patch checks if a full line of characters is fitting in these 70% and otherwise uses the available screen width, if it is not enough.

You can see the result in the second screenshot ("grub-640x480-editor.png") attached. There is now much more room for the editor, without loosing the 70% style if enough space is available.

Could you please apply that patch or give any feedback?

Thanks!

 Tilmann Bubeck


--
+-------+-------------------------------------------------------------+
|       | dr. tilmann bubeck               reinform medien- und       |
|       |                                  informationstechnologie AG |
| rein  | fon  : +49 (711) 7 82 76-52      loeffelstr. 40             |
| form  | fax  : +49 (711) 7 82 76-46      70597 stuttgart / germany  |
|    AG | cell.: +49 (172) 8 84 29 72      fon: +49 (711) 75 86 56-10 |
|       | email: address@hidden      http://www.reinform.de     |
|       +-------------------------------------------------------------+
|       | pflichtangaben nach paragraph 80, AktG:                     |
|       | reinform medien- und informationstechnologie AG, stuttgart  |
|       | handelsregister stuttgart, HRB 23001                        |
|       | vorstand:     dr. tilmann bubeck (vorsitz)                  |
|       | aufsichtsrat: frank stege (vorsitz)                         |
+-------+-------------------------------------------------------------+

Attachment: grub-unchanged-640x480-editor.png
Description: PNG image

Attachment: grub-640x480-editor.png
Description: PNG image

Attachment: change-term-width.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]