Re: [PATCH] gfxterm: check elements' properties and hadle errors.

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 04.03.2013 12:27, Vladimir Testov wrote:

> +  else
> +    {
> +      return GRUB_ERR_IO;
> +    }

This is not a correct error handling. You should never return an error
without calling grub_error. Also in all these contexts you handle the
cases of unknown property name. I don't feel like refusing to load a
theme because of unknown property is a good idea. This would i.a.
exclude older GRUB versions for newer themes even if property in
question is minor in meaning. Compare this to a browser refusing to show
a page because of unknown tag attribute. Also GRUB_ERR_IO hardly
describes a condition of unknown property.

signature.asc
Description: OpenPGP digital signature