[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [3/4] [PATCH] start angle (option of circular_progress) is measured
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities |
|
Date: |
Tue, 19 Mar 2013 08:00:36 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 |
On 15.03.2013 17:52, Andrey Borzenkov wrote:
> В Wed, 13 Mar 2013 14:52:13 +0400
> Vladimir Testov <address@hidden> пишет:
>
>> In current state, start angle is measured in "parrots", where 1 "parrot" = 1
>> /
>> 256 of full circle.
>>
>> With simple patch we can set start angle in degrees (which makes no
>> difference
>> for the program, but makes configuration to be more user-friendly)
>>
>
> This has compatibility issue and probably cannot be done without
> introducing theme file format version.
>
> What about adding new parameter name instead (although start_angle_angle
> looks rather silly)?
>
It would be better to have some kind of angle format. I think it would
be reasonable to use:
start_angle = 90°;
The only problem is start ° is a non-ASCII character and while GRUB
handles those fine, it is easily corrupted on transmission.
>>
>> theme.txt:
>>
>> before:
>> start_angle = -64
>> after:
>> start_angle = -90
>>
>> nothing else is affected
>>
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
signature.asc
Description: OpenPGP digital signature