Re: Linux console corruption when booted with terminal_output=console after rev 4789 (Decrease reported width by one to compensate for cursor algorithm problem.)

[Andrey Borzenkov]

В Mon, 08 Apr 2013 18:51:15 +0200
Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:

> On 08.04.2013 18:40, Andrey Borzenkov wrote:
> 
> > В Mon, 08 Apr 2013 18:34:27 +0200
> > Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> > 
> >> On 08.04.2013 17:51, Andrey Borzenkov wrote:
> >>
> >>> See http://susepaste.org/75296605
> >>>
> >>> Notice that screen width is reported as 79. 
> >>>
> >>> This is absolutely reproducible with and without plymouth.
> >>>
> >>
> >> Try this please
> >> === modified file 'grub-core/loader/i386/linux.c'
> >> --- grub-core/loader/i386/linux.c  2013-03-22 20:01:28 +0000
> >> +++ grub-core/loader/i386/linux.c  2013-04-08 16:33:08 +0000
> >> @@ -547,6 +547,10 @@
> >>        linux_params.video_cursor_x = pos >> 8;
> >>        linux_params.video_cursor_y = pos & 0xff;
> >>        linux_params.video_width = grub_term_width (term);
> >> +#ifdef GRUB_MACHINE_PCBIOS
> >> +      if (grub_strcmp (term->name, "console") == 0)
> >> +        linux_params.video_width++;
> > 
> > This is looks like piling hacks on hacks. What was wrong with my patch?
> > Just curious.
> > 
> 
> Its absence. There was no patch attached to the mail or included in it.
> Point me to it if I'm missing something.

http://lists.gnu.org/archive/html/grub-devel/2013-02/msg00086.html 

> 
> >> +#endif
> >>        linux_params.video_height = grub_term_height (term);
> >>        found = 1;
> >>        break;
> >>
> >>
> >>> _______________________________________________
> >>> Grub-devel mailing list
> >>> address@hidden
> >>> https://lists.gnu.org/mailman/listinfo/grub-devel
> >>>
> >>
> >>
> >>
> > 
> > 
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> 
> 
>

signature.asc
Description: PGP signature