[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] multistring support in gui_label
From: |
Vladimir Testov |
Subject: |
Re: [PATCH] multistring support in gui_label |
Date: |
Wed, 17 Apr 2013 10:56:26 +0400 |
User-agent: |
KMail/4.9.5 (Linux/3.5.0-26-generic; KDE/4.9.5; x86_64; ; ) |
On Tuesday, April 16, 2013 09:10:23 PM Andrey Borzenkov wrote:
> > +/* Differs from grub_font_draw_line only in multiline output */
>
> You mean grub_font_draw_string? Is it possible to extend this function
> instead of duplicating it?
Hmmm... I'll think through it. Would it be wise? The sets of parameteres in
these two functions are very different and the code is totally different...
> All nested functions were removed from trunk. Please do not reintroduce
> them. This should not even compile.
My fault. Made the patch for grub-2.00, and forgot to remade it for upstream
version. I've noticed that nested functions were removed. I will remake it
soon.
I've included the patch more for seeing the idea. It is not complete and (I
think) shouldn't be included in the upstream until two problems, I've
mentioned in previous letter, are not fixed. :)
Thank for the reply.
--
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru
- Re: [PATCH] multistring support in gui_label, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/04/03
- Re: [PATCH] multistring support in gui_label, Vladimir Testov, 2013/04/16
- Re: [PATCH] multistring support in gui_label, Andrey Borzenkov, 2013/04/16
- Re: [PATCH] multistring support in gui_label,
Vladimir Testov <=
- Re: [PATCH] multistring support in gui_label, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/04/17
- Re: [PATCH] multistring support in gui_label, Vladimir Testov, 2013/04/17
- Re: [PATCH] multistring support in gui_label, Vladimir Testov, 2013/04/17
- Re: [PATCH] multistring support in gui_label, Vladimir Testov, 2013/04/17
- Re: [PATCH] multistring support in gui_label, Vladimir 'φ-coder/phcoder' Serbinenko, 2013/04/17
- Re: [PATCH] multistring support in gui_label, Vladimir Testov, 2013/04/23
- [RFC][PATCH] multistring support in gui_label, Vladimir Testov, 2013/04/23