[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms
From: |
Francesco Lavra |
Subject: |
Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms |
Date: |
Sat, 11 May 2013 20:00:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 |
On 05/09/2013 08:08 PM, Leif Lindholm wrote:
> Attached is a patch that:
> - incoorporates Francesco's bug fixes
> - splits out relocation work into dl_helper.c
> - cleans up code slightly
> - makes relocations use le_to_cpu/cpu_to_le
> - changes all grub_util printout calls to grub_dprintf
[...]
> === modified file 'util/grub-mkimagexx.c'
> --- util/grub-mkimagexx.c 2013-04-12 14:53:58 +0000
> +++ util/grub-mkimagexx.c 2013-05-09 16:34:59 +0000
> @@ -542,7 +542,6 @@
> grub_util_info (" ABS32:\toffset=%d\t(0x%08x)",
> (int) sym_addr, (int) sym_addr);
> /* Data will be naturally aligned */
> - // sym_addr -= offset;
> sym_addr += 0x400;
This 0x400 constant still bothers me a bit :)
--
Francesco