[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] use grub_util_exec_redirect_all to silence "moprobe efiv
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH 2/2] use grub_util_exec_redirect_all to silence "moprobe efivars" |
|
Date: |
Mon, 16 Dec 2013 19:29:51 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 |
Go ahead for both patches.
Could you also add a grub_util_info detailing which directories were
tried and if they were found or not? To provide info about why GRUB
assumed this or that platform.
On 16.12.2013 19:20, Andrey Borzenkov wrote:
> ---
> grub-core/osdep/linux/platform.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/grub-core/osdep/linux/platform.c
> b/grub-core/osdep/linux/platform.c
> index ec67aad..86561f7 100644
> --- a/grub-core/osdep/linux/platform.c
> +++ b/grub-core/osdep/linux/platform.c
> @@ -69,8 +69,8 @@ grub_install_get_default_x86_platform (void)
> anyway later. So it should be safe to
> try to load it here.
> */
> - grub_util_exec ((const char * []){ "modprobe", "-q",
> - "efivars", NULL });
> + grub_util_exec_redirect_all ((const char * []){ "modprobe", "efivars",
> NULL },
> + NULL, NULL, "/dev/null");
> if (is_not_empty_directory ("/sys/firmware/efi"))
> {
> if (is_64_kernel ())
>
signature.asc
Description: OpenPGP digital signature