Re: [PATCH] Improve DejaVuSans detection

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 18.01.2014 18:04, Andrey Borzenkov wrote:
> В Sat, 18 Jan 2014 17:26:16 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> 
>> On 18.01.2014 16:58, Andrey Borzenkov wrote:
>>> Look also in /usr/share/fonts/truetype, it is installed in this path on
>>> openSUSE.
>>>
>>> Prefer DejaVuSansMono if found, on openSUSE DejaVuSans is proportional font.
>>>
>> It's not right solution. Proportional fonts must be preffered for
>> themes. Only terminal requires monospace fonts. You need to set
>> gfxterm_font to unifont name.
> 
> But then not gfxterm_font, but we need to set it in theme definition.
> gfxterm_font is optional and theme must still work without it.
> 
> From: Andrey Borzenkov <address@hidden>
> Subject: [PATCH] Improve DejaVuSans detection and fix starfield terminal font
> 
> Look also in /usr/share/fonts/truetype, it is installed in this path on
> openSUSE.
> 
> Add detected path name to summary output.
> 
> Set terminal font to unifont in starfield; DejaVuSans is proportional and 
> looks
> bad in terminal window.
> 
I've misread the patch in my first review. I thought it added a new
behaviour of looking for DejaVuSans.
> ---
>  configure.ac               | 3 ++-
>  themes/starfield/theme.txt | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index cf3de3b..8888c2f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1389,7 +1389,7 @@ fi
>  
>  if test x"$starfield_excuse" = x; then
>     for ext in pcf pcf.gz bdf bdf.gz ttf ttf.gz; do
> -     for dir in . /usr/src /usr/share/fonts/X11/misc 
> /usr/share/fonts/truetype/ttf-dejavu /usr/share/fonts/dejavu; do
> +     for dir in . /usr/src /usr/share/fonts/X11/misc 
> /usr/share/fonts/truetype/ttf-dejavu /usr/share/fonts/dejavu 
> /usr/share/fonts/truetype; do
Go ahead for this part.
>          if test -f "$dir/DejaVuSans.$ext"; then
>            DJVU_FONT_SOURCE="$dir/DejaVuSans.$ext"
>            break 2
> @@ -1816,6 +1816,7 @@ echo grub-mount: No "($grub_mount_excuse)"
>  fi
>  if [ x"$starfield_excuse" = x ]; then
>  echo starfield theme: Yes
> +echo With DejaVuSans font from $DJVU_FONT_SOURCE
Go ahead for this as well.
>  else
>  echo starfield theme: No "($starfield_excuse)"
>  fi
> diff --git a/themes/starfield/theme.txt b/themes/starfield/theme.txt
> index 5ec871b..b3b8d85 100644
> --- a/themes/starfield/theme.txt
> +++ b/themes/starfield/theme.txt
> @@ -25,7 +25,7 @@ message-font: "DejaVu Sans Regular 12"
>  message-color: "#000"
>  message-bg-color: "#fff"
>  terminal-box: "terminal_box_*.png"
> -terminal-font: "DejaVu Sans Regular 12"
> +terminal-font: "Gnu Unifont Mono Regular 16"
>  desktop-image: "starfield.png"
>  
On my system I get name "Unifont Regular 16". Did you check unicode.pf2
to get this string?
>  #help bar at the bottom
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

signature.asc
Description: OpenPGP digital signature