[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Support grub-emu on x32 (ILP32 but with x86-64 instruction set)
From: |
Colin Watson |
Subject: |
Re: Support grub-emu on x32 (ILP32 but with x86-64 instruction set) |
Date: |
Sun, 14 Sep 2014 21:02:44 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Sep 13, 2014 at 07:21:43PM +0400, Andrei Borzenkov wrote:
> > * configure.ac: Remove -m64 from checks for -mcmodel=large and
> > -mno-red-zone. These are always either unnecessary (x86_64-emu) or
> > already in TARGET_CFLAGS at this point, and they produce incorrect
> > results when building for x32.
>
> This was added to match what grub-core/Makefile.am actually uses. So
> basically either Makefile.am needs fixing as well or your patch does
> not fix the actual problem - meaning efiemu64.o will fail to compile.
That's fine. My change was not in the efiemu test, but in some similar
tests further down whose output is used to adjust TARGET_CFLAGS. It
would be incorrect to sync these tests with the manual rules for efiemu.
--
Colin Watson address@hidden