Re: make check: Tests for platform coreboot using temporary files fail

[Andrei Borzenkov]

В Sat, 11 Apr 2015 09:33:31 +0200
Paul Menzel <address@hidden> пишет:

> Dear GRUB developers,
> 
> 
> using Debian Sid/unstable, building GRUB from commit f11db3c (core:
> avoid NULL derefrence in grub_divmod64s) and running `make check`, all
> the tests using temporary files fail.
> 
>         $ ./autogen.sh
>         $ ./configure --with-platform=coreboot --enable-boot-time 
> --enable-cache-stats --enable-dependency-tracking
>         $ make -j
>         $ LANG=C make check
>         […]
>         
> ============================================================================
>         Testsuite summary for GRUB 2.02~beta2
>         
> ============================================================================
>         # TOTAL: 81
>         # PASS:  20
>         # SKIP:  17
>         # XFAIL: 0
>         # FAIL:  44
>         # XPASS: 0
>         # ERROR: 0
>         
> ============================================================================
>         See ./test-suite.log
>         Please report to address@hidden
>         
> ============================================================================
>         […]
>         $ more test-suite.log
>         […]
>         FAIL: grub_cmd_echo
>         ===================
> 
>         cp: cannot stat '': No such file or directory

it is due to

if [ x$boot = xcoreboot ]; then
    imgfile=`mktemp "${TMPDIR:-/tmp}/tmp.XXXXXXXXXX"` || exit 1
    cp "${GRUB_COREBOOT_ROM}" "${imgfile}"

According to docs/grub.texi

Following variables must be defined:

@multitable  @columnfractions .30 .65
@item GRUB_PAYLOADS_DIR @tab directory containing the required kernels
@item GRUB_CBFSTOOL @tab cbfstoll from Coreboot package (for coreboot platform 
only)
@item GRUB_COREBOOT_ROM @tab empty Coreboot ROM
@item GRUB_QEMU_OPTS @tab additional options to be supplied to QEMU
@end multitable

I have no experience with coreboot so I do not know what "empty
Coreboot ROM" is.

>         […]
> 
> The temporary files are present in the temporary directory, `/tmp` in my
> case. Is that expected?
> 
> `test-suite.log` is attached.
> 
> 
> Thanks,
> 
> Paul

pgpJxzx9yR0JJ.pgp
Description: OpenPGP digital signature