[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] grub-core/lib/libgcrypt/cipher/rijndael.c 2 warnings.
|
From: |
Andrei Borzenkov |
|
Subject: |
Re: [PATCH] grub-core/lib/libgcrypt/cipher/rijndael.c 2 warnings. |
|
Date: |
Wed, 15 Apr 2015 08:16:24 +0300 |
В Mon, 13 Apr 2015 20:32:53 +0300
Toomas Soome <address@hidden> пишет:
> hi!
>
> just checked the git://git.gnupg.org/libgcrypt.git - apparently it has been
> changed compared to one included in grub; the int i versus unsigned keylen is
> still there (visual inspection), the { } were inserted to if (0) ;
> statement.
>
> so second half is already fixed. I did report the signed/unsigned compare
> issue to gcrypt-devel, but then the question is about updating libcgrypt in
> grub;
It gets updated every now and then. "Upstream first" makes sure that if
we add local patch it won't be lost next time library is pulled in.
Just to be sure - these are just warnings, right? They do not cause
build failure or any regression?