[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ofdisk: allocate space for vscsi table
|
From: |
Paulo Flabiano Smorigo |
|
Subject: |
Re: [PATCH] ofdisk: allocate space for vscsi table |
|
Date: |
Mon, 9 Nov 2015 09:59:34 -0200 |
On Mon, Nov 9, 2015 at 8:46 AM, Vladimir 'φ-coder/phcoder' Serbinenko
<address@hidden> wrote:
> On 09.11.2015 02:33, Paulo Flabiano Smorigo wrote:
>> + /* 64 entries should be enough */
>> + table_size = sizeof (grub_uint64_t) * 64;
> Can we do something better than assuming a particular upper limit? You
> don't even pass this limit to the function in any way. You basically get
> a buffer overflow. Should we perhaps pass the limit in nentries? Or do
> something similar?
For sas there is an input attribute called max that I use as an upper
limit. AFAIK, vscsi method doesn't have it. nentries is a output
attribute.
I'll investigate it.
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>