Re: [PATCH] bootp: set is_def while processing dhcp ack

[Andrei Borzenkov]

On Thu, Mar 17, 2016 at 9:16 AM, Nikunj A Dadhania
<address@hidden> wrote:
> Andrei Borzenkov <address@hidden> writes:
>
>> On Wed, Mar 16, 2016 at 1:16 PM, Nikunj A Dadhania
>> <address@hidden> wrote:
>>> Hi Andrei,
>>>
>>>> If you call net_bootp manually,
>>>
>>> Thats what we are using in this current case, booting from the disk,
>>> and the grub.cfg has a netboot entry.
>>>
>>> menuentry 'Linux dev netboot' --class os {
>>>      insmod net
>>>      insmod ofnet
>>>      insmod tftp
>>>
>>>      net_bootp
>>>
>>>      echo 'Network status: '
>>>      net_ls_cards
>>>      net_ls_addr
>>>      net_ls_routes
>>>
>>>      echo 'Loading Linux ...'
>>>      linux  (tftp)/ubuntu-installer/ppc64el/vmlinux tasks=standard 
>>> pkgsel/language-pack-patterns= pkgsel/install-language-support=false --- 
>>> quiet
>>>      initrd     (tftp)/ubuntu-installer/ppc64el/initrd.gz
>>> }
>>>
>>
>> OK, so you attempt to configure everything. The first obvious question
>> is - *which* interface should now become default? Your patch would
>> make them compete, whoever is the last would win.
>>
>> We would need to define some mechanism to designate interface as "default" 
>> here.
>>
>>>> server is stored in environment variable net_<if>_dhcp_server_name;
>>>> you are free to use it as needed, e.g. set $root and $prefix.
>>>>
>>
>> You can already fetch this information from environment. Something like
>>
>> for i in 0 1 2 3 4 5; do
>>   eval "set ip=\$net_ofnet${i}_dhcp_server"
>
> I dont see net_ofnet0_dhcp_server or net_ofnet_dhcp_server set
>

This should be net_ofnet0_dhcp_server_name, sorry. What variables are
set (could you show full list)?

>>   if [ -n "$ip" ]; then
>>     set boot_from=tftp,$ip
>>     break
>>   fi
>> done
>>
>> And later use ($boot_from) everywhere.
>
> Regards
> Nikunj
>