[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] build: Use AC_HEADER_MAJOR to find device macros
From: |
Mike Gilbert |
Subject: |
[PATCH] build: Use AC_HEADER_MAJOR to find device macros |
Date: |
Sat, 16 Apr 2016 17:34:58 -0400 |
Depending on the OS/libc, device macros may be found in 3 places:
sys/types.h
sys/mkdev.h
sys/sysmacros.h
glibc currenctly defines the major/minor/makedev macros in sys/sysmacros.h
and includes this from sys/types.h. Based on mailing list discussion,
this may be removed from sys/types.h in a future glibc release.
---
configure.ac | 3 ++-
grub-core/osdep/devmapper/getroot.c | 6 ++++++
grub-core/osdep/devmapper/hostdisk.c | 5 +++++
grub-core/osdep/linux/getroot.c | 6 ++++++
grub-core/osdep/unix/getroot.c | 4 +++-
5 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 57e1713..9ddfc53 100644
--- a/configure.ac
+++ b/configure.ac
@@ -388,7 +388,8 @@ fi
# Check for functions and headers.
AC_CHECK_FUNCS(posix_memalign memalign getextmntent)
-AC_CHECK_HEADERS(sys/param.h sys/mount.h sys/mnttab.h sys/mkdev.h limits.h)
+AC_CHECK_HEADERS(sys/param.h sys/mount.h sys/mnttab.h limits.h)
+AC_HEADER_MAJOR
AC_CHECK_MEMBERS([struct statfs.f_fstypename],,,[$ac_includes_default
#include <sys/param.h>
diff --git a/grub-core/osdep/devmapper/getroot.c
b/grub-core/osdep/devmapper/getroot.c
index 05eda50..72e5582 100644
--- a/grub-core/osdep/devmapper/getroot.c
+++ b/grub-core/osdep/devmapper/getroot.c
@@ -40,6 +40,12 @@
#include <limits.h>
#endif
+#if defined(MAJOR_IN_MKDEV)
+#include <sys/mkdev.h>
+#elif defined(MAJOR_IN_SYSMACROS)
+#include <sys/sysmacros.h>
+#endif
+
#include <libdevmapper.h>
#include <grub/types.h>
diff --git a/grub-core/osdep/devmapper/hostdisk.c
b/grub-core/osdep/devmapper/hostdisk.c
index 19c1101..a697bcb 100644
--- a/grub-core/osdep/devmapper/hostdisk.c
+++ b/grub-core/osdep/devmapper/hostdisk.c
@@ -24,6 +24,11 @@
#include <errno.h>
#include <limits.h>
+#if defined(MAJOR_IN_MKDEV)
+#include <sys/mkdev.h>
+#elif defined(MAJOR_IN_SYSMACROS)
+#include <sys/sysmacros.h>
+#endif
#ifdef HAVE_DEVICE_MAPPER
# include <libdevmapper.h>
diff --git a/grub-core/osdep/linux/getroot.c b/grub-core/osdep/linux/getroot.c
index 10480b6..09e7e6e 100644
--- a/grub-core/osdep/linux/getroot.c
+++ b/grub-core/osdep/linux/getroot.c
@@ -35,6 +35,12 @@
#include <limits.h>
#endif
+#if defined(MAJOR_IN_MKDEV)
+#include <sys/mkdev.h>
+#elif defined(MAJOR_IN_SYSMACROS)
+#include <sys/sysmacros.h>
+#endif
+
#include <grub/types.h>
#include <sys/ioctl.h> /* ioctl */
#include <sys/mount.h>
diff --git a/grub-core/osdep/unix/getroot.c b/grub-core/osdep/unix/getroot.c
index 1079a91..4bf37b0 100644
--- a/grub-core/osdep/unix/getroot.c
+++ b/grub-core/osdep/unix/getroot.c
@@ -51,8 +51,10 @@
#endif
#include <sys/types.h>
-#if defined(HAVE_SYS_MKDEV_H)
+#if defined(MAJOR_IN_MKDEV)
#include <sys/mkdev.h>
+#elif defined(MAJOR_IN_SYSMACROS)
+#include <sys/sysmacros.h>
#endif
#if defined(HAVE_LIBZFS) && defined(HAVE_LIBNVPAIR)
--
2.8.1
- [PATCH] build: Use AC_HEADER_MAJOR to find device macros,
Mike Gilbert <=
- Re: [PATCH] build: Use AC_HEADER_MAJOR to find device macros, Andrei Borzenkov, 2016/04/17
- Re: [PATCH] build: Use AC_HEADER_MAJOR to find device macros, Mike Gilbert, 2016/04/17
- Re: [PATCH] build: Use AC_HEADER_MAJOR to find device macros, Andrei Borzenkov, 2016/04/17
- [PATCH v2] build: Use AC_HEADER_MAJOR to find device macros, Mike Gilbert, 2016/04/17
- Re: [PATCH v2] build: Use AC_HEADER_MAJOR to find device macros, Vladimir 'phcoder' Serbinenko, 2016/04/18
- Re: [PATCH v2] build: Use AC_HEADER_MAJOR to find device macros, Mike Gilbert, 2016/04/18
- [PATCH v3] build: Use AC_HEADER_MAJOR to find device macros, Mike Gilbert, 2016/04/19
- Re: [PATCH v3] build: Use AC_HEADER_MAJOR to find device macros, Andrei Borzenkov, 2016/04/24