[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: "arm_coreboot: Support DMA" breaks arm64
|
From: |
Leif Lindholm |
|
Subject: |
Re: "arm_coreboot: Support DMA" breaks arm64 |
|
Date: |
Tue, 30 May 2017 16:28:01 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, May 24, 2017 at 12:35:51PM +0100, Leif Lindholm wrote:
> Apologies for delay, got knocked out by a bad cold.
>
> On Thu, May 11, 2017 at 06:33:34PM +0000, Vladimir 'phcoder' Serbinenko wrote:
> > > Thoughts?
> > >
> > I don't think that functions in cache.h are used outside of kernel on arm64
> > currently. We can just remove cache.h from the list of exported headers
>
> That's true. So, would something like the below be acceptable?
Or would a new AM_CONDITIONAL be preferable?
Once the 32/64-bit ARM UEFI linux loaders are unified, the same change
should probably be made for the 32-bit port, so there is a case for
doing it that way.
Maybe COND_efi? Although that could require a workaround for ia64.
/
Leif
> diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am
> index 1045138..622f946 100644
> --- a/grub-core/Makefile.am
> +++ b/grub-core/Makefile.am
> @@ -66,7 +66,9 @@ CLEANFILES += grub_script.yy.c grub_script.yy.h
>
> include $(srcdir)/Makefile.core.am
>
> +if !COND_arm64
> KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/cache.h
> +endif
> KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/command.h
> KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/device.h
> KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/disk.h