[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] grub-install: locale depends on nls
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v3] grub-install: locale depends on nls |
|
Date: |
Tue, 17 Apr 2018 19:45:28 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Fri, Apr 13, 2018 at 11:36:49PM +0200, Olaf Hering wrote:
> With --disable-nls no locales exist.
>
> Avoid runtime error by moving code that copies locales into its own
> function. Return early in case nls was disabled. That way the compiler
> will throw away unreachable code, no need to put preprocessor
> conditionals everywhere to avoid warnings about unused code.
>
> Fix memleak by freeing dstf.
s/dstf/srcf and dstf/?
> Convert tabs to spaces in moved code.
>
> Signed-off-by: Olaf Hering <address@hidden>
Otherwise LGTM. If there are no objections I will commit
this patch in a week or so.
Daniel