[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/7] Avoiding scanning for an already not found device.
From: |
Goffredo Baroncelli |
Subject: |
[PATCH 4/7] Avoiding scanning for an already not found device. |
Date: |
Tue, 24 Apr 2018 21:13:13 +0200 |
If a device is missing, create the entry in data->devices_attached[] array.
This avoid un-necessary devices rescan.
Signed-off-by: Goffredo Baroncelli <address@hidden>
---
grub-core/fs/btrfs.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c
index 745bb854e..d6c3adbe4 100644
--- a/grub-core/fs/btrfs.c
+++ b/grub-core/fs/btrfs.c
@@ -586,7 +586,7 @@ find_device_iter (const char *name, void *data)
}
static grub_device_t
-find_device (struct grub_btrfs_data *data, grub_uint64_t id, int do_rescan)
+find_device (struct grub_btrfs_data *data, grub_uint64_t id)
{
struct find_device_ctx ctx = {
.data = data,
@@ -598,12 +598,9 @@ find_device (struct grub_btrfs_data *data, grub_uint64_t
id, int do_rescan)
for (i = 0; i < data->n_devices_attached; i++)
if (id == data->devices_attached[i].id)
return data->devices_attached[i].dev;
- if (do_rescan)
- grub_device_iterate (find_device_iter, &ctx);
- if (!ctx.dev_found)
- {
- return NULL;
- }
+
+ grub_device_iterate (find_device_iter, &ctx);
+
data->n_devices_attached++;
if (data->n_devices_attached > data->n_devices_allocated)
{
@@ -615,7 +612,8 @@ find_device (struct grub_btrfs_data *data, grub_uint64_t
id, int do_rescan)
* sizeof (data->devices_attached[0]));
if (!data->devices_attached)
{
- grub_device_close (ctx.dev_found);
+ if (ctx.dev_found)
+ grub_device_close (ctx.dev_found);
data->devices_attached = tmp;
return NULL;
}
@@ -856,7 +854,7 @@ grub_btrfs_read_logical (struct grub_btrfs_data *data,
grub_disk_addr_t addr,
" for laddr 0x%" PRIxGRUB_UINT64_T "\n", paddr,
addr);
- dev = find_device (data, stripe->device_id, j);
+ dev = find_device (data, stripe->device_id);
if (!dev)
{
grub_dprintf ("btrfs",
@@ -933,7 +931,8 @@ grub_btrfs_unmount (struct grub_btrfs_data *data)
unsigned i;
/* The device 0 is closed one layer upper. */
for (i = 1; i < data->n_devices_attached; i++)
- grub_device_close (data->devices_attached[i].dev);
+ if (data->devices_attached[i].dev)
+ grub_device_close (data->devices_attached[i].dev);
grub_free (data->devices_attached);
grub_free (data->extent);
grub_free (data);
--
2.17.0
- [PATCH V2] Add support for BTRFS raid5/6 to GRUB, Goffredo Baroncelli, 2018/04/24
- [PATCH 1/7] Add support for reading a filesystem with a raid5 or raid6 profile., Goffredo Baroncelli, 2018/04/24
- [PATCH 2/7] Add helper to check the btrfs header., Goffredo Baroncelli, 2018/04/24
- [PATCH 3/7] Move from the find_device the error logging logic to the callee., Goffredo Baroncelli, 2018/04/24
- [PATCH 4/7] Avoiding scanning for an already not found device.,
Goffredo Baroncelli <=
- [PATCH 5/7] Refactor the code of read from disk, Goffredo Baroncelli, 2018/04/24
- [PATCH 6/7] Add support for recovery for a raid5 btrfs profiles., Goffredo Baroncelli, 2018/04/24
- [PATCH 7/7] Add raid6 recovery., Goffredo Baroncelli, 2018/04/24