[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/9] btrfs: move the error logging from find_device() to its
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 3/9] btrfs: move the error logging from find_device() to its callee. |
Date: |
Wed, 30 May 2018 12:25:36 +0200 |
User-agent: |
Mutt/1.3.28i |
On Wed, May 16, 2018 at 08:48:13PM +0200, Goffredo Baroncelli wrote:
> This is a preparatory patch. The callee knows better if this
s/callee/caller/
> error is fatal or not, i.e. another available disk.
s/i.e. another available disk./e.g. another disk is available or not./
And I think that you can reverse order of the sentences above.
WRT the subject:
s/Move the error logging logic from find_device() to the callee./
Move the error logging from find_device() to its caller/
Otherwise LGTM.
Daniel
- [PATCH V4] Add support for BTRFS raid5/6 to GRUB, Goffredo Baroncelli, 2018/05/16
- [PATCH 1/9] btrfs: add support for reading a filesystem with a RAID 5 or RAID 6 profile., Goffredo Baroncelli, 2018/05/16
- [PATCH 2/9] btrfs: add helper to check the btrfs header., Goffredo Baroncelli, 2018/05/16
- [PATCH 5/9] btrfs: move logging code in grub_btrfs_read_logical(), Goffredo Baroncelli, 2018/05/16
- [PATCH 6/9] btrfs: refactor the code that read from disk, Goffredo Baroncelli, 2018/05/16
- [PATCH 3/9] btrfs: move the error logging from find_device() to its callee., Goffredo Baroncelli, 2018/05/16
- Re: [PATCH 3/9] btrfs: move the error logging from find_device() to its callee.,
Daniel Kiper <=
- [PATCH 4/9] btrfs: avoiding a rescan for a device which was already not founded., Goffredo Baroncelli, 2018/05/16
- [PATCH 7/9] btrfs: add support for recovery for a RAID 5 btrfs profiles., Goffredo Baroncelli, 2018/05/16
- [PATCH 8/9] btrfs: make more generic the code for RAID 6 rebuilding, Goffredo Baroncelli, 2018/05/16
- [PATCH 9/9] btrfs: add RAID 6 recovery for a btrfs filesystem., Goffredo Baroncelli, 2018/05/16