Re: [PATCH v3] Add travis-ci config file

[Alexander Graf]

> Am 20.02.2019 um 21:46 schrieb Daniel Kiper <address@hidden>:
> 
>> On Tue, Feb 19, 2019 at 04:34:08PM +0100, Alexander Graf wrote:
>> There is a really convenient service for open source project from Travis
>> CI: They allow for free CI testing using their infrastructure.
>> 
>> Grub has had issues with broken builds for various targets for a long time
>> already. The main reason is a lack of CI to just do smoke tests on whether
>> all targets still at least compile.
>> 
>> This patch adds a travis config file which builds (almost) all currently
>> available targets.
>> 
>> On top of that, this travis config also runs a small execution test on the
>> x86_64-efi target.
>> 
>> All of this config file can easily be extended further on. It probably makes
>> sense to do something similar to the u-boot test infrastructure that
>> communicates with the payload properly. Going forward, we also will want to
>> do more qemu runtime checks for other targets.
>> 
>> Currently, with this config alone, I already see about half of the available
>> targets as broken. So it's definitely desperately needed :).
>> 
>> Signed-off-by: Alexander Graf <address@hidden>
>> 
>> ---
>> 
>> v1 -> v2:
>> 
>>  - Fix comment about toolchain variable
>> 
>> v2 -> v3:
>> 
>>  - s/grub/GRUB/
>>  - remove unneeded packages
>>  - comment fixes
>>  - determine number of jobs dynamically
>>  - sort targets alphabetically
>> ---
>> .travis.yml | 117 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 117 insertions(+)
>> create mode 100644 .travis.yml
>> 
>> diff --git a/.travis.yml b/.travis.yml
>> new file mode 100644
>> index 000000000..9a6f58ff6
>> --- /dev/null
>> +++ b/.travis.yml
>> @@ -0,0 +1,117 @@
>> +# SPDX-License-Identifier: GPL-3.0+
>> +# Originally Copyright Roger Meier <address@hidden>
>> +# Adapted for GRUB by Alexander Graf <address@hidden>
>> +
>> +# build GRUB on Travis CI - https://travis-ci.org/
>> +
>> +dist: xenial
>> +
>> +language: c
>> +
>> +addons:
>> +  apt:
>> +    packages:
>> +    - cppcheck
>> +    - bc
>> +    - build-essential
>> +    - libsdl1.2-dev
>> +    - python
>> +    - python-virtualenv
>> +    - swig
>> +    - libpython-dev
>> +    - wget
>> +    - device-tree-compiler
>> +    - lzop
>> +    - liblz4-tool
>> +    - libisl15
>> +    - qemu-system
>> +    - ovmf
>> +    - unifont
> 
> Still have an itching to ask you to trim it down... Just build one
> target to reduce your wait time to minimum.  If everything works
> then re-enable all of them.

Why? Installing the packages takes a few seconds of ghe build time at most. 
Also, I don't see anything obviously superfluous.

> 
>> +env:
>> +  global:
>> +    # Include all cross toolchain paths, so we can just call them later down
>> +    - 
>> PATH=/tmp/qemu-install/bin:/tmp/grub/bin:/usr/bin:/bin:/tmp/cross/gcc-8.1.0-nolibc/aarch64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/arm-linux-gnueabi/bin:/tmp/cross/gcc-8.1.0-nolibc/ia64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/mips64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/powerpc64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/riscv32-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/riscv64-linux/bin:/tmp/cross/gcc-8.1.0-nolibc/sparc64-linux/bin
> 
> Should not you put /usr/bin:/bin at the end of the PATH? Or even
> /tmp/qemu-install/bin:/tmp/grub/bin:/usr/bin:/bin? Otherwise you
> may use during build not these tools which you expect.

The cross tools only install prefixed binaries (aarch64-linux-gcc) - and even 
if something unprefixed did sneak in, we really only ever want to use the 
prefixed ones :). So the end of PATH is definitely correct.

Alex