[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] loader/i386/linux: Calculate the setup_header length
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] loader/i386/linux: Calculate the setup_header length |
|
Date: |
Tue, 2 Apr 2019 16:01:11 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Mon, Apr 01, 2019 at 10:17:46AM -0400, Ross Philipson wrote:
> On 04/01/2019 07:10 AM, Daniel Kiper wrote:
> > On Fri, Mar 29, 2019 at 11:55:12AM -0400, Ross Philipson wrote:
> >> On 03/29/2019 11:09 AM, Daniel Kiper wrote:
> >>> From: Andrew Jeddeloh <address@hidden>
> >>>
> >>> Previously the setup_header length was just assumed to be the size of the
> >>> linux_kernel_params struct. The linux x86 32-bit boot protocol says that
> >>> the size of the linux_i386_kernel_header is 0x202 + the byte value at
> >>> 0x201
> >>> in the linux_i386_kernel_header. Calculate the size of the header, rather
> >>> than assume it is the size of the linux_kernel_params struct.
> >>>
> >>> Additionally, add some required members to the linux_kernel_params
> >>> struct and align the content of linux_i386_kernel_header struct with
> >>> it. New members naming was taken directly from Linux kernel source.
> >>>
> >>> linux_kernel_params and linux_i386_kernel_header structs require more
> >>> cleanup. However, this is not urgent, so, let's do this after release.
> >>> Just in case...
> >>>
> >>> Signed-off-by: Andrew Jeddeloh <address@hidden>
> >>> Signed-off-by: Daniel Kiper <address@hidden>
[...]
> So I think you should change the above from size to end an with that:
>
> Reviewed-by: Ross Philipson <address@hidden>
Updated and pushed. Thank you for review.
Daniel