[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ieee1275: Null pointer dereference in grub_ieee1275_encode_d
|
From: |
Colin Watson |
|
Subject: |
Re: [PATCH] ieee1275: Null pointer dereference in grub_ieee1275_encode_devname |
|
Date: |
Tue, 2 Apr 2019 18:24:07 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Apr 02, 2019 at 09:40:31AM -0700, Eric Snowberg wrote:
> Function grub_strndup may return NULL, this is called from function
> grub_ieee1275_get_devname which is then called from function
> grub_ieee1275_encode_devname to set device. The device variable
> could then be used with a NULL pointer.
Makes sense to me, and the handling matches how the
immediately-following possible grub_malloc failure is handled.
Reviewed-by: Colin Watson <address@hidden>
--
Colin Watson address@hidden