Re: [PATCH v3 06/10] travis: Add smoke tests for arm and aarch64

[Leif Lindholm]

On Tue, Jun 04, 2019 at 12:27:30PM +0200, Alexander Graf wrote:
> We've had an arm regression in grub recently where grub would not even
> be able to boot up anymore. So let's include arm and aarch64 in our
> simple "hello world" smoke tests as well.
> 
> For OVMF on ARM to work, we need a newer version of QEMU, add a PPA
> dependency for it.

On the whole, this looks good. *But* the default arm target here is now
armv5t, which is a very different beast from armv7-a (enabled in a
separate patch).

I'm not saying we need to do a full
- armv5t
- armv6
- armv7-a (A32/T32)
- armv7-a (A32 only)
matrix from day 1, but I think it's worth being explicit about which
instruction set we are tasting (also in case the default changes with
future toolchain releases, or we decide to switch where we get our
toolchains from).

So could you add a CFLAGS=-march=armv5t to the arm test?

/
    Leif

> Signed-off-by: Alexander Graf <address@hidden>
> Reviewed-by: Daniel Kiper <address@hidden>
> 
> ---
> 
> v2 -> v3:
> 
>   - Use 19.03 release firmware files
> ---
>  .travis.yml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 7945efa14..d6b827960 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -11,6 +11,8 @@ language: c
>  
>  addons:
>    apt:
> +    sources:
> +    - sourceline: 'ppa:jacob/virtualisation'
>      packages:
>      - libsdl1.2-dev
>      - lzop
> @@ -32,6 +34,8 @@ before_script:
>    - for i in $CROSS_TARGETS; do
>          ( cd /tmp/cross; wget -t 3 -O - 
> https://mirrors.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/x86_64-gcc-8.1.0-nolibc-$i.tar.xz
>  | tar xJ );
>      done
> +  - if [[ "$GRUB_TARGETS" == *"arm64-efi"* ]]; then wget 
> http://releases.linaro.org/reference-platform/enterprise/firmware/open-source/19.03/release/qemu-aarch64/QEMU_EFI.fd
>  -O QEMU_EFI.aarch64.fd; fi
> +  - if [[ "$GRUB_TARGETS" == *"arm-efi"* ]]; then wget 
> http://releases.linaro.org/reference-platform/enterprise/firmware/open-source/19.03/release/qemu-arm/QEMU_EFI.fd
>  -O QEMU_EFI.arm.fd; fi
>  
>  script:
>    # Comments must be outside the command strings below, or the Travis parser
> @@ -71,7 +75,9 @@ script:
>    - ( for target in $GRUB_TARGETS; do grub-mkimage -c grub.cfg -p / -O 
> $target -o grub-$target echo reboot normal || exit; done )
>  
>    # Run images we know how to run.
> -  - if [[ "$GRUB_TARGETS" == *"x86_64-efi"* ]]; then qemu-system-x86_64 
> -bios /usr/share/ovmf/OVMF.fd -m 512 -no-reboot -nographic -net nic -net 
> user,tftp=.,bootfile=grub-x86_64-efi | tee grub.log && grep "hello world" 
> grub.log; fi
> +  - if [[ "$GRUB_TARGETS" == *"x86_64-efi"* ]]; then qemu-system-x86_64      
>                     -bios /usr/share/ovmf/OVMF.fd -m 512 -no-reboot 
> -nographic -net nic -net user,tftp=.,bootfile=grub-x86_64-efi | tee grub.log 
> && grep "hello world" grub.log; fi
> +  - if [[ "$GRUB_TARGETS" == *"arm64-efi"* ]];  then qemu-system-aarch64 -M 
> virt -cpu cortex-a57 -bios QEMU_EFI.aarch64.fd     -m 512 -no-reboot 
> -nographic -net nic -net user,tftp=.,bootfile=grub-arm64-efi  | tee grub.log 
> && grep "hello world" grub.log; fi
> +  - if [[ "$GRUB_TARGETS" == *"arm-efi"* ]];    then qemu-system-arm     -M 
> virt -cpu cortex-a15 -bios QEMU_EFI.arm.fd         -m 512 -no-reboot 
> -nographic -net nic -net user,tftp=.,bootfile=grub-arm-efi    | tee grub.log 
> && grep "hello world" grub.log; fi
>  
>  matrix:
>    include:
> -- 
> 2.16.4
>