[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add %X option to printf functions.
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH] Add %X option to printf functions. |
|
Date: |
Thu, 19 Sep 2019 14:00:31 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
Hello Daniel,
Thanks for the quick feedback.
On 9/18/19 3:00 PM, Daniel Kiper wrote:
> On Tue, Sep 17, 2019 at 05:54:44PM +0200, Javier Martinez Canillas wrote:
>> From: Paulo Flabiano Smorigo <address@hidden>
>>
>> Signed-off-by: Paulo Flabiano Smorigo <address@hidden>
>> Signed-off-by: Javier Martinez Canillas <address@hidden>
>
> May I ask you to add an explanation to the commit message why?
> If you do that you can add "Reviewed-by: Daniel Kiper <address@hidden>".
>
The reason why we had this patch is that a following patch was using this
%X format specifier to print IP addresses as uppercase hexadecimal.
But as Vladimir suggested, we could just use %x and grub_toupper(). So If
adding an %X format specifier seems unnecessary and would only make grub
core bigger, then I'll just change the other patch and drop this one.
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat