Re: [PATCH v2 5/6] luks: Move configuration of ciphers into cryptodisk

[Daniel Kiper]

On Tue, Nov 05, 2019 at 07:58:39AM +0100, Patrick Steinhardt wrote:
> The luks module contains quite a lot of logic to parse cipher and
> cipher-mode strings like "aes-xts-plain64" into constants to apply them
> to the `grub_cryptodisk_t` structure. This code will be required by the
> upcoming luks2 module, as well, which is why this commit moves it into
> its own function `grub_cryptodisk_setcipher` in the cryptodisk module.
> While the strings are probably rather specific to the LUKS modules, it

I am not very happy with moving specific LUKS stuff into rather generic
cryptodisk module but probably there is no easier/better/... solution here.

> certainly does make sense that the cryptodisk module houses code to set
> up its own internal ciphers instead of hosting that code in the luks
> module.
> Signed-off-by: Patrick Steinhardt <address@hidden>

AIUI this is move of exact logic from luks.c into cryptodisk.c without
any functional changes in the code. If this is the case please state
that in the commit message. And then you can add my RB.

Daniel