[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm64: make sure fdt has #address-cells and #size-cells prop
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH] arm64: make sure fdt has #address-cells and #size-cells properties |
|
Date: |
Thu, 7 Nov 2019 18:39:26 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 |
Hello Leif,
On 11/7/19 5:40 PM, Leif Lindholm wrote:
> On Thu, Oct 31, 2019 at 11:37:40AM +0100, Javier Martinez Canillas wrote:
>> From: Mark Salter <address@hidden>
>>
>> Recent upstream changes to kexec-tools relies on #address-cells
>> and #size-cells properties in the FDT. If grub2 needs to create
>> a chosen node, it is likely because firmware did not provide one.
>> In that case, set #address-cells and #size-cells properties to
>> make sure they exist.
>
> I assumed we fixed that in 347210a5d5ce
> ("efi/fdt: Set address/size cells to 2 for empty tree")?
>
That indeed seems to be the case. I missed that was already fixed when
rebasing Mark's patch because the fix was a different one.
So it's another patch that can be dropped from our package, thanks a
lot for pointing it out.
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat