Re: [PATCH] ofnet: Fix incorrect mask for ppc64

[Vladimir 'phcoder' Serbinenko]

On Fri, 13 Dec 2019, 15:56 Vladimir 'phcoder' Serbinenko, <address@hidden> wrote:

---------- Forwarded message ---------
From: Vladimir 'phcoder' Serbinenko <address@hidden>
Date: Fri, 13 Dec 2019, 15:56
Subject: Re: [PATCH] ofnet: Fix incorrect mask for ppc64
To: Javier Martinez Canillas <address@hidden>

On Fri, 13 Dec 2019, 15:33 Javier Martinez Canillas, <address@hidden> wrote:

Hello Vladimir,

Thanks a lot for your feedback.

On 10/31/19 12:58 PM, Vladimir 'phcoder' Serbinenko wrote:
> Please don't chain swap_bytes32 with le_to_cpu32 as it's a less readable
> equivalent of be_to_cpu32
>

That's correct. In fact I think that the patch is wrong and what we should
do is just to drop the grub_le_to_cpu32() instead. I'll get access to a
ppc64le machine to test and post a v2 doing that.

ppc64le machine boots in big-endian mode. The only supported architecture with BE OFW is i386-ieee1275 but I'm not even sure there are i386-ieee1275 machines with ofnet. 

I mean LE OFW. Given that IP addresses are generally stored in BE order, I think be_to_cpu32 is reasonable but probably no machine is impacted either way.

Maybe some qemu config could have i386-ieee1275 with ofnet but generally i386-ieee1275 is dead target

Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat