[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] verifiers: fix calling uninitialized function pointer
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH] verifiers: fix calling uninitialized function pointer |
|
Date: |
Tue, 18 Feb 2020 12:44:30 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/18/20 11:08 AM, Michael Chang wrote:
> The necessary check for null before use of function ver->close is not
> taking place in the failure path. This patch simply adds the missing
> check and fixes the problem that grub hangs indefinitely after booting
> rogue image without valid signature if secure boot turned on.
>
> Now it displays like this for booting rogue uefi image.
>
> error: bad shim signature
> error: you need to load the kernel first
>
> Press any key to continue...
>
> and then you can go back to boot menu by pressing any key or after a few
> seconds expired.
>
> Signed-off-by: Michael Chang <address@hidden>
> ---
Reviewed-by: Javier Martinez Canillas <address@hidden>
Best regards,
Javier