[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 04/12] kern: Add grub_debug_enabled()
From: |
Javier Martinez Canillas |
Subject: |
[PATCH v2 04/12] kern: Add grub_debug_enabled() |
Date: |
Wed, 4 Mar 2020 12:58:43 +0100 |
From: Peter Jones <address@hidden>
Add a grub_debug_enabled() helper function instead of open coding it.
Signed-off-by: Peter Jones <address@hidden>
Signed-off-by: Javier Martinez Canillas <address@hidden>
Reviewed-by: Daniel Kiper <address@hidden>
---
grub-core/kern/misc.c | 21 ++++++++++++++++-----
include/grub/misc.h | 1 +
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c
index 76e7fb22872..d205fb1342e 100644
--- a/grub-core/kern/misc.c
+++ b/grub-core/kern/misc.c
@@ -158,17 +158,28 @@ int grub_err_printf (const char *fmt, ...)
__attribute__ ((alias("grub_printf")));
#endif
+int
+grub_debug_enabled (const char * condition)
+{
+ const char *debug;
+
+ debug = grub_env_get ("debug");
+ if (!debug)
+ return 0;
+
+ if (grub_strword (debug, "all") || grub_strword (debug, condition))
+ return 1;
+
+ return 0;
+}
+
void
grub_real_dprintf (const char *file, const int line, const char *condition,
const char *fmt, ...)
{
va_list args;
- const char *debug = grub_env_get ("debug");
-
- if (! debug)
- return;
- if (grub_strword (debug, "all") || grub_strword (debug, condition))
+ if (grub_debug_enabled (condition))
{
grub_printf ("%s:%d: ", file, line);
va_start (args, fmt);
diff --git a/include/grub/misc.h b/include/grub/misc.h
index ee48eb7a726..585c2a7644c 100644
--- a/include/grub/misc.h
+++ b/include/grub/misc.h
@@ -322,6 +322,7 @@ grub_puts (const char *s)
}
int EXPORT_FUNC(grub_puts_) (const char *s);
+int EXPORT_FUNC(grub_debug_enabled) (const char *condition);
void EXPORT_FUNC(grub_real_dprintf) (const char *file,
const int line,
const char *condition,
--
2.24.1
- [PATCH v2 00/12] A set of trivial patches from the Fedora package, Javier Martinez Canillas, 2020/03/04
- [PATCH v2 01/12] linux/getroot: Handle rssd storage device names, Javier Martinez Canillas, 2020/03/04
- [PATCH v2 02/12] efi: Print more debug info in our module loader, Javier Martinez Canillas, 2020/03/04
- [PATCH v2 03/12] Makefile: Make libgrub.pp depend on config-util.h, Javier Martinez Canillas, 2020/03/04
- [PATCH v2 05/12] normal/completion: Fix possible NULL pointer dereference, Javier Martinez Canillas, 2020/03/04
- [PATCH v2 04/12] kern: Add grub_debug_enabled(),
Javier Martinez Canillas <=
- [PATCH v2 06/12] efi/gop: Add support for BLT_ONLY adapters, Javier Martinez Canillas, 2020/03/04
- [PATCH v2 07/12] efi/uga: Use 64 bit for fb_base, Javier Martinez Canillas, 2020/03/04
- [PATCH v2 09/12] efi: Print error messages to grub_efi_allocate_pages_real(), Javier Martinez Canillas, 2020/03/04
- [PATCH v2 11/12] efi/gop: Add debug output on GOP probing, Javier Martinez Canillas, 2020/03/04
- [PATCH v2 08/12] kern: Make grub_error() more verbose, Javier Martinez Canillas, 2020/03/04